Declare SQLite for the functional tests - #59
Open
jacobmichels wants to merge 2 commits into
Open
Conversation
This was referenced Sep 5, 2026
jacobmichels
force-pushed
the
jacob/tecnix-functional-tests-sqlite
branch
from
September 6, 2026 00:15
3fac8ae to
745bd34
Compare
jacobmichels
changed the base branch from
main
to
jacob/tecnix-provenance-write-race
September 6, 2026 00:16
jacobmichels
marked this pull request as draft
September 6, 2026 03:17
jacobmichels
force-pushed
the
jacob/tecnix-functional-tests-sqlite
branch
from
September 10, 2026 17:34
745bd34 to
ba8719c
Compare
jacobmichels
removed this pull request from stack #62
September 10, 2026 17:35
jacobmichels
added this pull request to stack #65
September 10, 2026 17:35
jacobmichels
marked this pull request as ready for review
September 10, 2026 17:36
jacobmichels
removed this pull request from stack #65
September 10, 2026 20:35
jacobmichels
force-pushed
the
jacob/tecnix-functional-tests-sqlite
branch
from
September 10, 2026 20:36
ba8719c to
d9f961a
Compare
jacobmichels
changed the base branch from
jacob/tecnix-provenance-write-race
to
jacob/tecnix-gc-stack-bounds
September 10, 2026 20:36
jacobmichels
added this pull request to stack #66
September 10, 2026 20:36
The cache tests invoke sqlite3 directly. Declare it in the isolated test package instead of relying on development-shell tools.
The VM invokes the functional tests with its own runtimeInputs, so the package nativeBuildInputs do not put sqlite3 on its PATH. Include SQLite for the cache rejection and revision isolation tests. Assisted-By: devx/f59ca034-15b4-4cf6-a5c2-492b3ece7ba4
jacobmichels
force-pushed
the
jacob/tecnix-functional-tests-sqlite
branch
from
September 11, 2026 16:01
d9f961a to
ad4580b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache tests in #57 and #58 invoke
sqlite3, but the isolated functional-test package does not provide it. All six test jobs fail when the tests reach that command. Development-shell checks missed the undeclared dependency.Add
sqliteto the package arguments andnativeBuildInputsintests/functional/package.nix.nativeBuildInputslists the tools available inside the isolated build. This is two added lines, with no changes to evaluator behavior or test assertions.This PR is the bottom layer of the native GitHub stack: #59 → #57 → #58. It supplies the SQLite test dependency for the two feature layers above it.
Checks